The Wayback Machine - http://web.archive.org/web/20150915101528/http://chatlogs.musicbrainz.org/musicbrainz-devel/2012/2012-04/2012-04-16.html

IRC log of musicbrainz-devel on 2012-04-16

Timestamps are in UTC.

00:14:41 [ruaok]
ruaok has joined #musicbrainz-devel
00:22:04 [ianmcorvidae]
navap: replied, also 'rtab' wouldn't work, but I think 'retab' does :P
00:22:26 [ianmcorvidae]
perhaps re\t
00:23:32 [reosarevok]
:p
00:23:35 [navap]
Why not rtab?
00:23:46 [reosarevok]
Stop destroying my name :p
00:23:50 [navap]
If it weren't for me, I'd say it should juse be R/I/N in the topic :)
00:23:50 [ianmcorvidae]
because we also have ruaok!
00:23:56 [navap]
oh haha, wow
00:24:16 [reosarevok]
And for n we have yourself, navap :p
00:24:25 [navap]
That much I managed to remember :)
00:24:29 [ianmcorvidae]
haha
00:25:06 [ianmcorvidae]
I feel like R/I/N would probably be understood as reosarevok/me/nikki anyway; I is clearly me and what other combination of an R and and N do I usually team up with :P
00:25:49 [navap]
heh, make it so!
00:26:47 [ianmcorvidae]
ianmcorvidae has changed the topic to: Next dev meeting on monday April 16th, agenda: review, testing schema change branches (warp), daily code review (reotab/ian/ocharles?), beta spec (r/i/n), web interface ratelimit (reotab), robots.txt (reotab/nikki), post-schema-change schedule (reotab)
00:26:55 [ianmcorvidae]
of course, that's the only one that has that particular set of three :P
00:27:48 [navap]
Boo, I was hoping expecting stuff like (r/i/o) and (r)
00:28:06 [navap]
(we only have one 'o' right?)
00:28:12 [reosarevok]
navap: don't worry, I *think* we won't be making it longer
00:28:19 [ianmcorvidae]
heh, rio
00:37:44 [voiceinsideyou]
voiceinsideyou has joined #musicbrainz-devel
00:39:41 [ianmcorvidae]
for the CAA: https://twitter.com/#!/anamanaguchi/status/191686771216617472 :)
00:41:42 [navap]
heh
00:42:03 [ianmcorvidae]
that album was released digitally first, with an actual animated .gif as the cover, of course, but :)
00:42:15 [ianmcorvidae]
er, s/album/single/, anyway
00:42:40 [nikki]
and you won't be able to upload it :(
00:42:48 [ianmcorvidae]
no :(
00:55:46 [Merco]
Merco has joined #musicbrainz-devel
01:14:24 [_eLiXiR_]
_eLiXiR_ has joined #musicbrainz-devel
01:59:24 [navap]
ianmcorvidae: So what's the process to get a second server instance fired up?
01:59:38 [navap]
Do you have some time right now?
01:59:45 [ianmcorvidae]
I can set something up, yeah
02:00:14 [ianmcorvidae]
what we need is: a new mb_server checkout somewhere for it (probably just copy the one you have) and a new place for an FCGI socket
02:00:18 [ianmcorvidae]
and a new URL :)
02:01:59 [_eLiXiR__]
_eLiXiR__ has joined #musicbrainz-devel
02:06:09 [navap]
What do you need from me?
02:08:13 [ianmcorvidae]
probably what URL you want, I can come up with the rest
02:09:21 [navap]
uh, navap2.mbsandbox I guess?
02:09:34 [ianmcorvidae]
okay, that works XD
02:09:36 [navap]
I've already got a second check out sitting in my home
02:10:33 [eLiXiR]
eLiXiR has joined #musicbrainz-devel
02:11:47 [ianmcorvidae]
do you want your custom robots.txt shared between the two?
02:12:12 [ianmcorvidae]
* ianmcorvidae sets it up that way for now, it can be changed if need be later anyway
02:12:19 [navap]
I'd prefer it having its own robots.txt
02:12:30 [navap]
Well, maybe it doesn't matter
02:12:41 [ianmcorvidae]
I can just make it have its own, heh
02:12:50 [ianmcorvidae]
robots2.txt :)
02:13:01 [navap]
Sounds good
02:13:23 [ianmcorvidae]
the socket's gonna be $HOME/.fcgi.2.socket
02:15:05 [ianmcorvidae]
navap: okay, it's set up; use .fcgi.2.socket and robots2.txt
02:15:12 [ianmcorvidae]
and $HOME/musicbrainz-server2/
02:19:46 [navap]
We're live!
02:19:48 [navap]
Thanks ianmcorvidae
02:43:00 [ianmcorvidae]
navap: apparently navap2 is now ISEing :(
02:43:07 [navap]
Yeah
02:43:24 [ianmcorvidae]
oh
02:43:28 [navap]
I tried to access edit history
02:43:29 [ianmcorvidae]
don't use Cache::Memcached::Fast
02:43:34 [ianmcorvidae]
looking at the error log
02:43:55 [ianmcorvidae]
there's an error where it can't find a method forget_dead_hosts, that exists in Cache::Memcached but not ::Fast
02:43:59 [ianmcorvidae]
this is for session storage
02:44:19 [ianmcorvidae]
I'm not sure why the ::Fast thing is still in our default, I guess warp was intending to make a fix at some point, but
02:44:42 [navap]
THere's also a typo there, there's an extra set of braces
02:45:11 [ianmcorvidae]
I feel like there's a reason for the error, but yeah
02:45:13 [navap]
I'm now logged in and can navigate a little. Viewing edit history for an artist gives me a 502
02:46:18 [ianmcorvidae]
hm
02:46:21 [ianmcorvidae]
I can't even log in
02:46:24 [navap]
Seems to be fine now
02:46:49 [ianmcorvidae]
oh, huh, yeah
02:46:59 [navap]
ugh, again. edit history causes a 502
02:48:00 [ianmcorvidae]
hm, there's some error in the log about "upstream sent too big header while reading response header from upstream"
02:48:24 [navap]
Does the value of MEMCACHED_NAMESPACE matter?
02:48:47 [ianmcorvidae]
I mean, if it's not unique across rika then you're sharing data with whoever you're sharing data with
02:48:51 [ianmcorvidae]
I'd set it to something unique
02:49:35 [ianmcorvidae]
it's complaining a lot, incidentally, about "Use of uninitialized value $comment in concatenation (.) or string" in Plugin::Diff
02:49:39 [ianmcorvidae]
dunno if that's your doing though
02:50:18 [navap]
Shouldn't be
02:50:33 [navap]
* navap switches back to master just in case
02:51:03 [ianmcorvidae]
yeah, it's still showing up there
02:51:13 [ianmcorvidae]
presuming you're running with -r?
02:51:42 [navap]
Yes
02:52:48 [ianmcorvidae]
okay, all running servers I can find seem to be doing this
02:54:10 [navap]
502ing on viewing edit history?
02:54:21 [ianmcorvidae]
yeah
02:54:37 [ianmcorvidae]
looks like mine was still running (not sure why) but had the older debug error we found
02:55:08 [ianmcorvidae]
oh, hm, no, mine works fine after I fix that
02:56:59 [ianmcorvidae]
of course, umpteen million changes since then
02:57:00 [ianmcorvidae]
hm
03:02:27 [ianmcorvidae]
navap: incidentally, looks like the comment thing is you, it's a commit from april 5; not sure if it's to blame here though
03:02:45 [navap]
oops
03:02:51 [ianmcorvidae]
it is, however, not on my (working) sandbox
03:02:59 [navap]
Which commit is it?
03:03:12 [ianmcorvidae]
e2eb263a
03:03:35 [ianmcorvidae]
looks like you're adding comments to how artist credits are displayed in diffs
03:04:04 [ianmcorvidae]
you have an if($acn->artist->comment) { $comment = {some stuff} } else { $comment = undef; }
03:04:14 [ianmcorvidae]
it's throwing the error because of the undef, since you use $comment later
03:04:27 [ianmcorvidae]
(specifically, for: title => html_filter($acn->artist->sort_name . $comment) )
03:04:59 [navap]
ah, yeah
03:05:25 [ianmcorvidae]
so I guess we can see if fixing that fixes this as well?
03:05:29 [ianmcorvidae]
I don't have any other leads, sadly :/
03:06:49 [ianmcorvidae]
it's either that or something else that's changed since sometime late-February :P
03:07:00 [ianmcorvidae]
(helpful, I know)
03:08:21 [navap]
Well the problem isn't on musicbrainz.org, that's good
03:08:48 [navap]
I set $comment to '' instead of undef. Does that fix it?
03:08:49 [ianmcorvidae]
yeah, I imagine they'd have rolled back the last release if so
03:09:02 [ianmcorvidae]
on navap or navap2? (just to clarify)
03:09:14 [navap]
navap2
03:09:27 [navap]
This is getting confusing very fast :p
03:09:29 [ianmcorvidae]
looks like edits are loading now
03:09:36 [ianmcorvidae]
http://navap2.mbsandbox.org/artist/a3cb23fc-acd3-4ce0-8f36-1e5aa6a18432/edits works :)
03:09:39 [ianmcorvidae]
so I think that was the problem
03:09:48 [ianmcorvidae]
logs also aren't spewing lines about uninitialized values
03:10:12 [ianmcorvidae]
so yeah, I think that fixes both problems (that were, I guess, the same problem)
03:10:20 [navap]
I wonder why musicbrainz.org is unaffected though
03:10:45 [ianmcorvidae]
good question
03:10:54 [ianmcorvidae]
has there been a release since then?
03:11:00 [ianmcorvidae]
looks like, I guess
03:11:06 [navap]
Yes, we had one last week
03:11:20 [ianmcorvidae]
unless that commit happened before but it was merged after the release, I guess
03:11:39 [reosarevok]
* reosarevok guesses the Mr. Burns effect
03:11:50 [reosarevok]
So many conflicting bugs, some never actually appear
03:11:58 [reosarevok]
:p
03:12:09 [navap]
You mean to say that the bugs are buggy?
03:12:11 [reosarevok]
This is not related to the edit search, right?
03:12:22 [ianmcorvidae]
it should affect everything that displays edits
03:12:23 [reosarevok]
(because nikki reported that one being dead)
03:12:30 [ianmcorvidae]
which is to say, anything that displays diffs of artist credits
03:12:34 [reosarevok]
On beta or test, dunno
03:12:45 [ianmcorvidae]
maybe it's a unix sockets problem?
03:12:52 [ianmcorvidae]
I don't think production uses unix sockets
03:13:05 [reosarevok]
Did you see if it's on beta?
03:13:07 [ianmcorvidae]
* ianmcorvidae tries that edit page on beta
03:13:16 [ianmcorvidae]
heh, unrelated ISE
03:13:20 [ianmcorvidae]
greeeeeat
03:13:35 [reosarevok]
As I said then? You can't see the problem because of other problem? :D
03:13:52 [navap]
I can't even log in to test
03:14:34 [navap]
Ah, it finally gave me a 504
03:14:41 [ruaok]
ruaok has joined #musicbrainz-devel
03:15:01 [nikki]
I reported a bug to do with displaying edits
03:15:06 [ruaok]
ruaok has changed the topic to: Next dev meeting on monday April 17th, agenda: review, testing schema change branches (warp), daily code review (reotab/ian/ocharles?), beta spec (r/i/n), web interface ratelimit (reotab), robots.txt (reotab/nikki), post-schema-change schedule (reotab)
03:15:08 [ianmcorvidae]
nikki: beta or test?
03:15:11 [nikki]
beta
03:15:22 [ianmcorvidae]
hm, beta seems unaffected by this bug we found anyway
03:15:29 [ruaok]
ruaok has changed the topic to: Next dev meeting on monday April **17th**, agenda: review, testing schema change branches (warp), daily code review (reotab/ian/ocharles?), beta spec (r/i/n), web interface ratelimit (reotab), robots.txt (reotab/nikki), post-schema-change schedule (reotab)
03:15:43 [reosarevok]
¿?
03:15:48 [nikki]
monday the 17th?
03:15:55 [reosarevok]
Is the topic so long you're setting it never, ruaok? :D
03:16:39 [ruaok]
ruaok has changed the topic to: Next dev meeting on TUESDAY April **17th**, agenda: review, testing schema change branches (warp), daily code review (reotab/ian/ocharles?), beta spec (r/i/n), web interface ratelimit (reotab), robots.txt (reotab/nikki), post-schema-change schedule (reotab)
03:17:21 [nikki]
* nikki wonders if postponing it is such a good idea
03:17:27 [nikki]
a whole extra 24 hours for us to fill the topic more? :P
03:18:07 [nikki]
ianmcorvidae: ah, the ticket I entered was http://tickets.musicbrainz.org/browse/MBS-4558
03:19:06 [ianmcorvidae]
aaaand yeah, that's the error I was getting, but it's unrelated to the one we found on rika
03:19:20 [ianmcorvidae]
anyway, navap, you should push that change to codereview, if nothing else we don't want errors filling logs and things :)
03:19:28 [ianmcorvidae]
and it fixes your servers for now :/
03:20:08 [navap]
* navap starts the laborious process of creating a review
03:22:09 [ianmcorvidae]
I wonder how well post-review or whatever tool that is works
03:22:34 [ianmcorvidae]
that makes posting reviews a lot less laborious, I hear (I know aeontech got it working, too, not that he's been around for a while)
03:23:25 [navap]
I took a look at review board's docs on that and closed the tab. Looked way too complicated
03:23:43 [navap]
It's a wall of text that puts our topic to shame
03:23:57 [ianmcorvidae]
yeah, that was my take on it as well :P
03:25:28 [akuira]
akuira has joined #musicbrainz-devel
03:27:53 [navap]
There, review sent
03:32:15 [ianmcorvidae]
navap: thanks :)
03:32:16 [ianmcorvidae]
* ianmcorvidae reviewed
03:48:22 [navap]
* navap tries to update his transclusion table by downloading index.txt ... and fails
03:49:01 [navap]
http://navap.mbsandbox.org/static/wikidocs/index.txt vs http://navap.mbsandbox.org/admin/wikidoc
03:50:11 [ianmcorvidae]
might need to clear a cache key or something
03:51:30 [ianmcorvidae]
yeah
03:51:30 [ianmcorvidae]
hm
03:51:36 [ianmcorvidae]
you want to clear navap:wikidoc-index
03:51:59 [navap]
I changed MEMCACHED_NAMESPACE and it started working
03:52:06 [ianmcorvidae]
that would do it as well, yes
03:52:13 [navap]
How would I edit the contents of the cache?
03:52:23 [ianmcorvidae]
telnet, or a memcached library
03:52:28 [ianmcorvidae]
it's running on 11211, which is standard
03:53:29 [ianmcorvidae]
I think that telnet localhost 11211 and then 'delete navap:wikidoc-index' would do it
03:53:46 [ianmcorvidae]
if you want, I have a python script that dumps everything in the cache (sans contents, just the keys and sizes and things)
03:55:02 [navap]
Nah, changing the namespace is much easier for me :)
03:55:25 [ianmcorvidae]
well, that also kills any other caching you have set up
03:55:28 [ianmcorvidae]
and your sessions :)
03:56:00 [navap]
meh, it takes 3 seconds to log in
04:47:41 [WitchDoc]
WitchDoc has joined #musicbrainz-devel
04:49:09 [Witch_Doc]
hey all i've succesfully setup a musicbrainz ngs server on my ubuntu machine but am stuck trying to launch the loadreplicationchanges script
04:49:36 [Witch_Doc]
it's complaining about not being able to find aliased.pm
04:50:01 [ianmcorvidae]
did you install with carton?
04:50:15 [ianmcorvidae]
if so, you'll need to run LoadReplicationChanges within carton exec, like you do with the server
04:50:17 [Witch_Doc]
but the file does exist in /home/musicbrainz/musicbrainz-server/local/lib/perl5
04:50:33 [Witch_Doc]
hmm ok let me try that
04:50:35 [ianmcorvidae]
yes, you need to run with carton
04:50:38 [ianmcorvidae]
otherwise it doesn't know to look there
04:50:47 [ianmcorvidae]
as you'll see if you look through the listing of @PATH it gives you with the error :)
04:51:14 [Witch_Doc]
that seems to work
04:51:46 [Witch_Doc]
so next question is how do i launch the server as a service?
04:52:03 [ianmcorvidae]
define "as a service" :)
04:52:04 [Witch_Doc]
and what would my crontab command be for the replication?
04:52:17 [Witch_Doc]
have it launch on startup
04:52:31 [Witch_Doc]
guess it's already a service ... just need to make it launch on system boot
04:52:39 [ianmcorvidae]
you'll need to write a startup script for it, yeah
04:53:14 [Witch_Doc]
hmm are there any startup scripts available that i could download?
04:53:17 [ianmcorvidae]
for crontab, there's an admin/cron/slave.sh
04:53:22 [ianmcorvidae]
not to my knowledge
04:53:30 [ianmcorvidae]
(you'll still need to run that slave.sh inside carton, incidentally, but)
04:53:49 [Witch_Doc]
so if i call the slave.sh script it'll launch the loadreplicationchanges using carton?
04:53:58 [ianmcorvidae]
no, you need to call slave.sh within carton
04:54:02 [Witch_Doc]
hmm ok
04:54:16 [Witch_Doc]
so why not just call the loadreplicationchanges instead of slave.sh?
04:54:19 [ianmcorvidae]
something like 'carton exec /path/to/your/musicbrainz-server/admin/cron/slave.sh 2> /dev/null
04:54:30 [ianmcorvidae]
slave.sh has some logging and things; you can just use loadreplicationchanges if you want though
04:54:34 [Witch_Doc]
oh ok
04:54:57 [Witch_Doc]
now i just need to figure out how to write the startup script and im done
04:55:07 [ianmcorvidae]
yeah, slave.sh logs to your server root/slave.log, and rotates the logs occasionally
04:55:35 [Witch_Doc]
how long does a loadreplicationchanges typically take?
04:55:49 [ianmcorvidae]
well, once you're up to date it shouldn't usually take much of any time
04:56:15 [ianmcorvidae]
you may still be catching up, though, depending what database dump you used -- and I know there was one packet a few months ago that took a really long time
04:56:26 [ianmcorvidae]
in general, though, pretty quick
04:56:28 [Witch_Doc]
i used yesterday's dump
04:56:39 [ianmcorvidae]
oh, okay, then you don't need to worry about that large packet anyway
04:57:01 [ianmcorvidae]
usually, though, you're only doing one packet at a time, which is pretty quick; I don't have exact timings off the top of my head but it's negligible
04:57:40 [Witch_Doc]
it's been running for about 6 minutes now
04:57:46 [Witch_Doc]
ok nevermind just finished
04:57:57 [ianmcorvidae]
well, you need to get all the hourly packets since the dump, at least, this first run :)
04:58:17 [Witch_Doc]
with last line saying Sun Apr 15 21:57:30 2012 : Replication packet #58371 not available
04:58:50 [Witch_Doc]
is that normal?
04:59:04 [ianmcorvidae]
that's normal, yeah, that packet will come out in a few minutes
04:59:09 [Witch_Doc]
oh ok
04:59:31 [ianmcorvidae]
after which it'll import that one and then tell you the one after that isn't available
04:59:34 [ianmcorvidae]
etc. :)
05:00:46 [Witch_Doc]
ahh i c
05:00:56 [Witch_Doc]
ok so now to test the slave.sh script
05:02:53 [Witch_Doc]
seems to work
05:03:03 [Witch_Doc]
now to just wait until my crontab fires
05:06:16 [Witch_Doc]
does anyone here have a startup script for ubuntu i could copy?
05:46:58 [plaintext]
plaintext has joined #musicbrainz-devel
07:56:43 [Merco]
Merco has joined #musicbrainz-devel
08:05:46 [djce]
djce has joined #musicbrainz-devel
08:22:13 [adhawkins]
adhawkins has joined #musicbrainz-devel
09:29:39 [ocharles]
NEW OFFICE!
09:29:47 [ocharles]
* ocharles does the new office dance
09:41:24 [djce1]
djce1 has joined #musicbrainz-devel
10:10:19 [ocharles]
ianmcorvidae: ping me about robots.txt/production nginx
10:28:02 [ijabz]
ijabz has joined #musicbrainz-devel
10:29:40 [ijabz]
Hi whats the status of the schema change stuff ?
10:30:45 [ocharles]
ijabz: in what sense, other than "in progress"? We haven't shipped anything yet, a few things are in review and mostly ready
10:31:24 [ijabz]
I mean have you decided which ones are definetly going to be done, and have defined the schema changes yet ?
10:31:47 [ocharles]
yep, see blog for that
10:35:25 [ijabz]
ok, got it so what Im really asking is some of these changes are going to break the web service,such as http://tickets.musicbrainz.org/browse/MBS-2532, and some things might no break the web service but it probably needs to be updated
10:35:46 [ijabz]
But I can't do anything until I can get my hands on a database with the correct schema
10:36:39 [ijabz]
So what I would like to do is make use a of such a database on test, when such a thing exists
10:36:52 [ocharles]
ok, that'll only happen as we complete work on this
10:37:16 [ocharles]
we haven't discussed getting stuff onto test yet, but I agree that's a good idea
10:37:28 [ocharles]
oh, warp's already put that in the agenda
10:38:52 [ijabz]
Ok great, I really need that as I don't have time or patience to start trying to patching my own database
10:40:27 [ijabz]
i don't think Im going to be able to make the meeting tomorrow
10:46:41 [ocharles]
ok, i'll try and represent you :)
10:46:44 [ocharles]
keep an eye on the logs
10:53:40 [ijabz]
ocharles: thx
10:57:45 [ianmcorvidae]
ocharles: ping, what about robots.txt?
10:57:54 [ocharles]
ianmcorvidae: you want to see production nginx stuff?
10:58:30 [ianmcorvidae]
well, I was just looking at that codereview and surmising that it's fixing the problem in the wrong way
10:58:46 [ianmcorvidae]
if you're talking about the robots.txt content-type one
10:59:21 [ianmcorvidae]
i.e., I think that whichever site they were having the problem on (test, maybe?) needs a mime.types import added (which I suspect is already on the production one)
10:59:57 [ocharles]
that sounds likely
11:00:13 [ianmcorvidae]
the codereview was adding a 'default_type text/plain' to the robots.txt location
11:00:23 [ocharles]
production does indeed have include /etc/nginx/mime.types;
11:00:24 [ianmcorvidae]
I figured fixing it right was probably more useful :)
11:00:37 [ocharles]
but so does test
11:00:41 [ocharles]
yea :)
11:00:50 [ianmcorvidae]
hm, test has that
11:00:51 [ianmcorvidae]
odd
11:01:20 [ocharles]
same default_type too
11:01:38 [ianmcorvidae]
oh, the patch added some default_type lines
11:01:42 [ianmcorvidae]
was what that was about
11:01:48 [ocharles]
i meant in nginx.conf
11:01:56 [ocharles]
in case production had a default_type of text, but it doesn't
11:02:03 [ocharles]
(they both have octet-stream
11:02:06 [djce]
djce has joined #musicbrainz-devel
11:02:06 [ianmcorvidae]
ah
11:02:06 [ianmcorvidae]
yeah
11:05:34 [ianmcorvidae]
oh, hm -- is it using the robots.txt.staging? Maybe it's not picking up the mimetype because of that
11:05:45 [ocharles]
oh, good point
11:06:13 [ianmcorvidae]
probably the default_type thing is right to fix that problem, then
11:06:33 [ocharles]
there is no robots.txt for beta, so .staging is probably confusing nginx
11:06:37 [ianmcorvidae]
yeah
11:07:17 [ocharles]
i'll ship that later
11:07:21 [ianmcorvidae]
yeah
11:09:05 [ianmcorvidae]
ocharles: there are some updates to production configs that need to happen at some point: http://tickets.musicbrainz.org/browse/MBS-4517
11:09:13 [ianmcorvidae]
just FYI, since we're talking about nginx configs :)
11:09:26 [ocharles]
hm, odd
11:09:37 [ocharles]
guess production isn't using symlinks
11:11:42 [ianmcorvidae]
couldn't say :)
11:19:55 [Merco]
Merco has joined #musicbrainz-devel
11:44:39 [Merco1]
Merco1 has joined #musicbrainz-devel
11:58:54 [djce]
djce has joined #musicbrainz-devel
12:11:39 [djce1]
djce1 has joined #musicbrainz-devel
13:05:50 [voiceinsideyou]
voiceinsideyou has joined #musicbrainz-devel
13:28:28 [warp]
oh, no meeting today.
13:28:33 [warp]
also, hello!
13:30:43 [navap]
Hi!
13:47:47 [ocharles]
eyup warp
14:36:06 [reosarevok]
reosarevok has joined #musicbrainz-devel
14:54:07 [ijabz_]
ijabz_ has joined #musicbrainz-devel
15:19:02 [ijabz_]
ijabz_ has joined #musicbrainz-devel
15:38:11 [hawke_1]
hawke_1 has joined #musicbrainz-devel
16:09:13 [ijabz_]
ijabz_ has joined #musicbrainz-devel
16:10:27 [ocharles]
this multiple ISWCs stuff is growing quite impressively
16:10:41 [andreypopp]
andreypopp has joined #musicbrainz-devel
16:25:24 [bitmap]
bitmap has joined #musicbrainz-devel
16:29:48 [demosdemon]
ocharles: just pushed to github (forgot when I made the patch)
16:30:16 [ocharles]
thanks
16:31:07 [ocharles]
demosdemon: you need to create a ticket too, if there isn't already one
16:31:10 [ocharles]
if there is, please link it to the review
16:33:39 [demosdemon]
http://tickets.musicbrainz.org/browse/MBS-4564
16:33:51 [ocharles]
ok, link the review to that then
16:33:58 [ocharles]
enter "MBS-4564" in the "bugs" field
16:35:27 [demosdemon]
and done
16:35:48 [ocharles]
thanks
16:36:33 [demosdemon]
no problem
16:36:44 [demosdemon]
figuring out all the nuances of codereview and github is fun
16:38:20 [ocharles]
you're doing really well :)
16:41:33 [ocharles]
ok, that should be shipped now
16:41:46 [ocharles]
grr, it's still trying to download it
16:46:37 [voiceinsideyou]
voiceinsideyou has joined #musicbrainz-devel
16:52:33 [_5moufl]
_5moufl has joined #musicbrainz-devel
16:55:58 [MBJenkins]
Project musicbrainz-server_master build #161: SUCCESS in 19 min: http://ci.musicbrainz.org/job/musicbrainz-server_master/161/
16:55:59 [MBJenkins]
* pavan: Fix uninitialized value $comment in concatenation
16:55:59 [MBJenkins]
* demosdemon: Fix robots.txt being served as an octet-stream on test.mb
16:56:00 [MBJenkins]
* demosdemon: Tab to spaces
17:02:39 [reosarevok]
:O
17:02:57 [reosarevok]
One build and success?
17:03:00 [reosarevok]
Magic :p
17:04:57 [Leftmost]
Leftmost has joined #musicbrainz-devel
17:04:57 [Leftmost]
Leftmost has joined #musicbrainz-devel
17:06:07 [MBJenkins]
Project musicbrainz-server_master build #162: FAILURE in 10 min: http://ci.musicbrainz.org/job/musicbrainz-server_master/162/
17:06:08 [MBJenkins]
* pavan: MBS-4551: Display active git branch
17:06:08 [MBJenkins]
* pavan: MBS-4551: Remove unnecessary IF
17:08:37 [reosarevok]
Yeah, two in a row would be too much
17:09:11 [demosdemon]
lol
17:12:16 [warp]
haha
17:13:48 [DWSR]
Do we have a git announce bot for this channel?
17:17:09 [voiceinsideyou1]
voiceinsideyou1 has joined #musicbrainz-devel
17:19:51 [voiceinsideyou2]
voiceinsideyou2 has joined #musicbrainz-devel
17:21:14 [reosarevok]
DWSR: no, we have a Jenkins announce bot, as its name implies :p
17:53:36 [hawke_2]
hawke_2 has joined #musicbrainz-devel
18:32:41 [bitmap]
bitmap has joined #musicbrainz-devel
18:53:09 [bitmap]
bitmap has joined #musicbrainz-devel
18:56:58 [the_metalgamer]
the_metalgamer has joined #musicbrainz-devel
19:06:15 [ocharles]
* ocharles returns home
19:11:02 [Leftmost]
To his own planet?
19:13:24 [warp]
where is home?
19:17:55 [CatCat]
CatCat has joined #musicbrainz-devel
19:18:06 [CatCat]
:x is the meting over/now
19:18:13 [reosarevok]
Look at the topic ;)
19:18:21 [CatCat]
yea isaw it right after talking
19:18:35 [warp]
today is monday. meeting is tomorrow.
19:18:47 [CatCat]
lol reotab
19:19:10 [CatCat]
when is this meeting?
19:19:20 [CatCat]
erh gmt
19:19:32 [warp]
CatCat: http://wiki.musicbrainz.org/Regular_Meeting_Time
19:19:33 [CatCat]
or cest, that works too
19:19:53 [CatCat]
woa meetings have a wikipage
19:19:57 [ijabz]
ijabz has joined #musicbrainz-devel
19:20:30 [CatCat]
so NOW but tomorrow
19:20:47 [warp]
yes.
19:21:01 [CatCat]
i'd be awesome if the meeting was always on tuesdays ....
19:21:15 [CatCat]
so sleeeepy on monday
19:22:09 [warp]
* warp likes them on mondays.
19:22:34 [warp]
they're annoyingly in the middle of my working day now though. I like them better in the evening.
19:23:05 [CatCat]
i'd like them one or two hours earlier myself.
19:23:16 [CatCat]
21 is so late
19:23:38 [CatCat]
i end up fall a slep
19:23:55 [reosarevok]
If you make them earlier, Rob is still asleep :p
19:25:48 [CatCat]
silly rob needs to be in this timesone :p
19:26:10 [CatCat]
really strange dream
19:26:24 [CatCat]
i dream that you, and warp and shep and rob was all stayign here for a summit
19:26:27 [CatCat]
heh
19:26:33 [the_metalgamer]
the_metalgamer has joined #musicbrainz-devel
19:33:01 [bitmap]
bitmap has joined #musicbrainz-devel
19:34:56 [adhawkins]
adhawkins has joined #musicbrainz-devel
19:41:49 [DWSR]
You guys looking for volunteers?
19:42:44 [adhawkins]
To do what? :)
19:42:49 [nikki]
yes :P
19:42:57 [DWSR]
Kinda anything?
19:43:26 [DWSR]
I have official training that amounts to somewhere between fuck and all, but I've dabbled in enough stuff that I can probably hit the ground running on anything that you need help with
19:43:46 [adhawkins]
How about a library for the CAA? :)
19:44:07 [adhawkins]
I have an empty github repository all ready :D
19:44:13 [DWSR]
CAA?
19:44:21 [adhawkins]
Cover Art Archive
19:44:32 [DWSR]
I assume we're writing either Python or JS?
19:44:34 [adhawkins]
It'll basically amount to a bit of http fetching and JSON parsing
19:44:43 [adhawkins]
No, C++ for me please!
19:44:48 [nikki]
well, mb has plenty of bits and pieces. there's the server which is perl, html and js, picard which is python, a bunch of libraries for the ws in various languages...
19:44:48 [adhawkins]
With a C interface too
19:44:52 [DWSR]
* DWSR eyes adhawkins shiftily.
19:45:06 [DWSR]
Never really touched C.
19:45:12 [DWSR]
Or any derivatives.
19:45:23 [adhawkins]
That rules that out then!
19:45:25 [DWSR]
I've touched a bunch of C-like languages though, so this probably shouldn't be too hard.
19:45:34 [adhawkins]
I dare say a python module for it would be appreciated too
19:45:43 [DWSR]
meh.
19:45:49 [DWSR]
I learn things pretty quickly either way.
19:45:55 [DWSR]
And Eclipse is so wonderful versatile.
19:46:02 [DWSR]
s/ful/fully/
19:47:56 [DWSR]
Would you care if the lib was in Java?
19:48:23 [DWSR]
Not sure how interop works between languages.
19:52:30 [DWSR]
adhawkins: Python 2 or 3?
19:52:51 [ijabz]
yes, more java please, search server is all written in Java
19:53:07 [adhawkins]
No idea really, I'm not a python expert
19:53:48 [ianmcorvidae]
we have python-musicbrainz2 which is for python2 and uses /ws/1 and we have python-musicbrainz-ngs, which uses /ws/2 and is compatible with python2 and python3 last I chicked
19:53:53 [ianmcorvidae]
checked*
19:54:23 [nikki]
oh, I forgot the search server
19:54:45 [DWSR]
I assume that there's a github repo(s) for all the things?
19:54:54 [reosarevok]
Some are svn
19:55:00 [reosarevok]
But mostly, yes
19:55:16 [ijabz]
svn.musicbrainz,org
19:55:49 [DWSR]
Considering you're split across VCSs, I assume that you're in the midst of migration?
19:55:55 [ianmcorvidae]
yeah, largely
19:56:02 [ianmcorvidae]
I think ultimately we'll move everything to git
19:56:12 [ianmcorvidae]
there's some projects in SVN that don't really get updated though
19:56:13 [DWSR]
Git's much nicer than SVN
19:56:28 [ianmcorvidae]
for example python-musicbrainz2, which is for our deprecated-but-still-exists ws/1
19:56:37 [DWSR]
ws/1?
19:56:39 [DWSR]
website?
19:56:41 [ianmcorvidae]
and some things that just don't get touched ever, like MBChatLogger
19:56:43 [reosarevok]
web service
19:56:49 [DWSR]
ah.
19:56:59 [ianmcorvidae]
musicbrainz.org/ws/1/ versus /ws/2, we usually just shorten it :)
19:57:05 [DWSR]
You guys don't have a master repo, do you?
19:57:07 [reosarevok]
MBChatLogger: touch
19:57:07 [MBChatLogger]
I'm logging. I don't understand 'touch', reosarevok. Try /msg MBChatLogger help
19:57:10 [DWSR]
That you just include things from?
19:57:18 [reosarevok]
MBChatLogger, where did the coder touch you?
19:57:18 [MBChatLogger]
I'm logging. Sorry, nothing found for 'where did the coder touch you'
19:57:46 [ianmcorvidae]
heh, we have three different places where code is, varying amounts of duplication
19:57:58 [ianmcorvidae]
svn.mb, git.mb, and github (both the metabrainz and musicbrainz accounts)
19:58:54 [DWSR]
You should be able to just create a master repo in github and 'include' the other repos.
19:59:21 [DWSR]
That way you get independant repos for every seperate project, but can just get master head and snag everything.
19:59:31 [DWSR]
For deployment, for example.
19:59:50 [ianmcorvidae]
deployment is also across a number of servers in a complex way :P
20:00:11 [ianmcorvidae]
what's in our current musicbrainz-server git repository is the only thing that really gets multiply-deployed
20:00:14 [DWSR]
Don't have a bash script called deploy?
20:00:14 [DWSR]
;)
20:00:44 [ianmcorvidae]
well, I don't know what's there on the backend, but probably not precisely :P
20:00:55 [DWSR]
lol
20:01:02 [ianmcorvidae]
the switch to carton improved our server install dramatically
20:01:04 [DWSR]
I remember working on a small seedbox farm.
20:01:23 [ianmcorvidae]
used to be installing what felt like half of CPAN, and a quarter of it would fail and you'd have to retry it manually :P
20:01:25 [DWSR]
And we just had a bash script on a central managment server called 'deploy' that would push any changes from the local git repo out to everything.
20:01:41 [DWSR]
ick
20:01:50 [DWSR]
You don't have a local CPAN repo?
20:02:15 [ianmcorvidae]
well, this is for everyone; even if we did it wouldn't help random contributors such as us :)
20:02:55 [plaintext]
plaintext has joined #musicbrainz-devel
20:03:18 [DWSR]
I'm just so used to having limited internet access.
20:03:39 [DWSR]
I've had a couple of times where I've mirrored CPAN or other similar repos for projects I was doing.
20:03:44 [ianmcorvidae]
on rika, the sandbox server that I manage, deployment *is* pretty easy though; it's mostly done with /etc/skel :P
20:04:59 [demosdemon]
-_-
20:05:01 [demosdemon]
502 on http://musicbrainz.org/user/ModBot/edits/accepted
20:05:02 [DWSR]
lol
20:05:19 [ianmcorvidae]
heh, unsurprising that that page takes >30 seconds to load I guess
20:05:20 [DWSR]
btw.
20:05:26 [DWSR]
http://scheduling.ocharles.org.uk/ <-- 502.
20:05:32 [DWSR]
That link is in the topic of #mb.
20:05:34 [ocharles]
hm
20:05:48 [ocharles]
oh yea, my server got turned off
20:05:59 [demosdemon]
autoedits for modbot loads
20:06:15 [demosdemon]
I'm just trying to find some notes by modbot
20:06:54 [DWSR]
ocharles: Oh, sorry, didn't think that that would highlight you
20:07:00 [ocharles]
i'm glad it has DWSR :)
20:07:45 [reosarevok]
ocharles, you're on time for defending Haskell as a language for MB stuff :p
20:08:07 [ocharles]
i'm also doing maths studying, no time for language debates :(
20:08:12 [demosdemon]
there's no search edit for noted by editor
20:08:13 [reosarevok]
Aww
20:08:15 [demosdemon]
*notes
20:08:30 [reosarevok]
demosdemon: there's also no search *in* notes, if you feel like coding ;)
20:08:39 [reosarevok]
* reosarevok could use that one
20:09:09 [demosdemon]
I was feeling bored and decided to work on http://tickets.musicbrainz.org/browse/MBS-4560
20:09:36 [reosarevok]
(and yeah, edit searches / screens 502'ing for huge entities and searches is common - not sure how possible it is to fix)
20:09:53 [demosdemon]
but I don't know how to word ModBod's note (or what to do for translation)
20:10:12 [reosarevok]
ianmcorvidae ^
20:10:17 [ianmcorvidae]
for edit notes, I think the answer right now is "don't worry about translation right this second"
20:10:39 [ianmcorvidae]
I'll look into modbot's edit notes and translating them during the summer
20:10:54 [demosdemon]
kk
20:10:54 [ianmcorvidae]
but edit notes *generally* we're not going to be able to translate, likely, so :/
20:10:57 [reosarevok]
For wording, I'd say something like "This edit to a high quality release has been rejected for lack of votes"
20:11:12 [ianmcorvidae]
go for "consistent with other ModBot edit notes", would be what I'd say :)
20:11:14 [reosarevok]
(if you're specifically looking at marking those, which would be ideal)
20:11:24 [ianmcorvidae]
(both code-wise and wording-wise)
20:18:07 [demosdemon]
the consistency is difficult if I can't find notes -_-
20:18:21 [demosdemon]
I'm going play with chemicals… I'll be work on that later
20:20:53 [Merco]
Merco has joined #musicbrainz-devel
20:21:16 [reosarevok]
demosdemon: can't you just look at the modbot code? The notes are pre-defined, so they should be there
20:21:33 [demosdemon]
there's strewn all over the place… I just found one seconds ago
20:21:37 [ianmcorvidae]
reosarevok: you say "the modbot code" like that's guaranteed to be in one place or organized :P
20:21:44 [demosdemon]
s/there's/they're
20:21:53 [reosarevok]
If it's not, then maybe that should be changed first? :)
20:22:34 [reosarevok]
Let's have stuff orga-nice-d!
20:22:41 [ianmcorvidae]
it's done by edit type, I think
20:22:45 [ianmcorvidae]
demosdemon: where did you find the one?
20:23:21 [lfranchi]
lfranchi has joined #musicbrainz-devel
20:23:56 [demosdemon]
lib/MusicBrainz/Server/Controller/Artist.pm
20:24:08 [ianmcorvidae]
... huh, in *controllers*
20:24:13 [ianmcorvidae]
yeah, that does seem a bit off, heh
20:25:34 [ianmcorvidae]
seems like modbot-added notes should be in the MusicBrainz::Server::Edit tree
20:26:36 [demosdemon]
well, modbot doesn't talk that much
20:26:53 [demosdemon]
a grep through the whole tree only finds ~6 modbot add_notes
20:27:13 [ianmcorvidae]
well, that doesn't mean it shouldn't be in a reasonable place, but :P
20:27:36 [demosdemon]
I'll be back tonight. I have wonderful chem lab :(
20:32:56 [ocharles]
scheduling is back
20:34:00 [ocharles]
as is as much of bookbrainz as is written :)
20:34:09 [ianmcorvidae]
haha
20:48:09 [bitmap]
bitmap has joined #musicbrainz-devel
21:01:49 [ijabz]
ijabz has joined #musicbrainz-devel
21:32:09 [DWSR]
Anyway.
21:32:21 [DWSR]
If I have a github account, can I get access to the github repos?
21:32:41 [DWSR]
Contributing to MB is probably going to be on my list of isht to do after upgrading all my Androids to ICS.
21:33:23 [ianmcorvidae]
just make a fork
21:33:32 [ianmcorvidae]
everything has to go through codereview anyway, you don't need commit access
21:33:38 [ianmcorvidae]
to the main ones
22:23:19 [Leftmost]
Leftmost has joined #musicbrainz-devel
22:23:19 [Leftmost]
Leftmost has joined #musicbrainz-devel
22:48:58 [ruaok]
ruaok has joined #musicbrainz-devel
23:31:53 [Merco]
Merco has joined #musicbrainz-devel
23:50:58 [ianmcorvidae]
ianmcorvidae has joined #musicbrainz-devel
23:50:58 [ianmcorvidae]
ianmcorvidae has joined #musicbrainz-devel
23:52:52 [kepstin]
kepstin has joined #musicbrainz-devel